Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SurveyModel: Rename parameters in the onCurrentPageChanging and onCurrentPageChanged event handlers #5355

Closed
RomanTsukanov opened this issue Dec 16, 2022 · 1 comment · Fixed by #5970
Closed

SurveyModel: Rename parameters in the onCurrentPageChanging and onCurrentPageChanged event handlers #5355

RomanTsukanov opened this issue Dec 16, 2022 · 1 comment · Fixed by #5970
Assignees
@andrewtelnov
Labels
API change Issues that request changes in the API
Milestone
v1.9.82

Comments

@RomanTsukanov
Copy link
Contributor

onCurrentPageChanging:

  • options.allowChanging -> options.allow (for consistency)

onCurrentPageChanging and onCurrentPageChanged:

  • options.isNextPage and options.isPrevPage - replace with options.isGoingBackwards
@RomanTsukanov RomanTsukanov added the API change Issues that request changes in the API label Mar 29, 2023
@OlgaLarina OlgaLarina added this to the v1.9.82 milestone Apr 4, 2023
andrewtelnov added a commit that referenced this issue Apr 9, 2023
@andrewtelnov
SurveyModel: Rename parameters in the onCurrentPageChanging and onCur…
23ccec6 
…rentPageChanged event handlers fixed #5355
@andrewtelnov
Copy link
Member

@RomanTsukanov isGoingBackwards !== isPrevPage. isPrevPage when a user press a previous button or goes exactly on a page before the current. isGoingBackwards should be true when a user goes to any page before the current.
The same story with the isGoingForwards.
I have added these two properties. 'allow' is already here.

Thank you,
Andrew

@andrewtelnov andrewtelnov mentioned this issue Apr 9, 2023
Merged
novikov82 pushed a commit that referenced this issue Apr 9, 2023
@andrewtelnov
SurveyModel: Rename parameters in the onCurrentPageChanging and onCur…
6323f12 
…rentPageChanged event handlers fixed #5355 (#5970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtelnov andrewtelnov

Labels
API change Issues that request changes in the API
Projects
None yet
Milestone
v1.9.82
Development

Successfully merging a pull request may close this issue.

SurveyModel: Rename parameters in the onCurrentPageChanging and onCur… surveyjs/survey-library
3 participants
@andrewtelnov @OlgaLarina @RomanTsukanov