Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File question: A wrong file is removed when the onDownloadFile event is used #6459

Closed
JaneSjs opened this issue Jun 30, 2023 · 1 comment · Fixed by #6467
Closed

File question: A wrong file is removed when the onDownloadFile event is used #6459

JaneSjs opened this issue Jun 30, 2023 · 1 comment · Fixed by #6467
Assignees
@dk981234
Labels
bug user issue An issue or bug reported by users
Milestone
v1.9.96

Comments

@JaneSjs
Copy link
Contributor

JaneSjs commented Jun 30, 2023 •
edited
Loading

User Issue: T13706 - Upload file deletes wrong file (angular)
https://surveyjs.answerdesk.io/internal/ticket/details/T13706.

Issue: when the survey.onDownloadFile is used, a wrong file appears after deleting a file.

Without the onDownloadFile callback - Works correctly (View Demo).
image

If you store an image identifier as a file's content, and handle the survey.onDownloadFile to display a file preview, a wrong file is removed: View Demo.
image

Test Images:
capibara1
capibara2
capibara3
@JaneSjs JaneSjs added bug user issue An issue or bug reported by users labels Jun 30, 2023
dk981234 added a commit that referenced this issue Jul 3, 2023
@dk981234
Work for #6459: fix deleting wrong file
cdd886a
@dk981234 dk981234 linked a pull request Jul 3, 2023 that will close this issue
File Question: fix deleting wrong file #6467
Merged
@OlgaLarina OlgaLarina added this to the v1.9.96 milestone Jul 4, 2023
@RomanTsukanov RomanTsukanov changed the title The File question - A wrong file is removed when the survey.onDownloadFile callback is used File question: A wrong file is removed when the onDownloadFile event is used Jul 4, 2023
@MattPil29
Copy link

thanks for fixing so quickly.

andrewtelnov added a commit that referenced this issue Jan 29, 2025
@andrewtelnov
e.toLowerCase is not a function on setting to survey.showProgressBar …
db29abd 
…boolean value fix #6459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk981234 dk981234

Labels
bug user issue An issue or bug reported by users
Projects
None yet
Milestone
v1.9.96
Development

Successfully merging a pull request may close this issue.

File Question: fix deleting wrong file surveyjs/survey-library
4 participants
@MattPil29 @OlgaLarina @dk981234 @JaneSjs