Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page paddings (in different modes) #6578

Closed
2 tasks
mikeamelin opened this issue Jul 24, 2023 · 3 comments · Fixed by #7048
Closed
2 tasks

Page paddings (in different modes) #6578

mikeamelin opened this issue Jul 24, 2023 · 3 comments · Fixed by #7048
Assignees
@tsv2013 @mikeamelin
Labels
bug theme builder website demos
Milestone
v1.9.111

Comments

@mikeamelin
Copy link

mikeamelin commented Jul 24, 2023 •
edited
Loading

  • padding below title

Image

  • padding above button

Image
@mikeamelin mikeamelin self-assigned this Jul 24, 2023
@mikeamelin mikeamelin added the bug label Jul 24, 2023
@mikeamelin mikeamelin changed the title Title padding (in different modes) Page paddings (in different modes) Jul 24, 2023
@tsv2013 tsv2013 self-assigned this Jul 26, 2023
@mikeamelin
Copy link
Author

Additional comments...

— title's padding depends on Survey Structure — they should be the same
— need to check padding for title and button for both appearance — default and panelless

Here is prototype — https://www.figma.com/file/jcuAUsN02n2yJerx39mqf9/Previews?type=design&node-id=175-235683&mode=design

@tsv2013
Copy link
Member

tsv2013 commented Aug 8, 2023

Additional design link - https://www.figma.com/file/jcuAUsN02n2yJerx39mqf9/Previews?node-id=263%3A487260&mode=dev
Check navigation buttons top margin for pages with single question

@mikeamelin
Copy link
Author

mikeamelin commented Aug 22, 2023 •
edited
Loading

Responsive Mode —

Image

tsv2013 pushed a commit that referenced this issue Sep 29, 2023
Fixed #6578 - Page paddings in different modes - added vr-tests
3fa7905
@tsv2013 tsv2013 linked a pull request Sep 29, 2023 that will close this issue
Fixed #6578 - Page paddings in different modes #7048
Merged
tsv2013 pushed a commit that referenced this issue Sep 29, 2023
Work for #6578 - Page paddings in different modes - updated screenshots
6928e9a
tsv2013 pushed a commit that referenced this issue Sep 29, 2023
Work for #6578 - Page paddings in different modes - updated screenshots
17eada6
tsv2013 pushed a commit that referenced this issue Sep 29, 2023
Work for #6578 - Page paddings in different modes - updated screenshots
a663a00
tsv2013 pushed a commit that referenced this issue Sep 29, 2023
Work for #6578 - Page paddings in different modes - updated screenshots
391dd4d
tsv2013 pushed a commit that referenced this issue Sep 29, 2023
Work for #6578 - Page paddings in different modes - updated screenshots
edb8931
tsv2013 pushed a commit that referenced this issue Oct 2, 2023
Work for #6578 - Page paddings in different modes - fixed row space
bb63fd1
tsv2013 pushed a commit that referenced this issue Oct 2, 2023
Work for #6578 - Page paddings in different modes - fixed description…
6d8e0bb 
… padding
tsv2013 pushed a commit that referenced this issue Oct 2, 2023
Work for #6578 - Page paddings in different modes - updated etalons
8106f18
tsv2013 pushed a commit that referenced this issue Oct 3, 2023
Work for #6578 - Page paddings in different modes - fixed vr-tests
5b0a033
novikov82 pushed a commit that referenced this issue Oct 3, 2023
@tsv2013
Fixed #6578 - Page paddings in different modes (#7048)
21e717b 
* Fixed #6578 - Page paddings in different modes - added vr-tests

* Work for #6578 - Page paddings in different modes - updated screenshots

* Work for #6578 - Page paddings in different modes - updated screenshots

* Work for #6578 - Page paddings in different modes - updated screenshots

* Work for #6578 - Page paddings in different modes - updated screenshots

* Work for #6578 - Page paddings in different modes - updated screenshots

* Work for #6578 - Page paddings in different modes - fixed row space

* Work for #6578 - Page paddings in different modes - fixed description padding

* Work for #6578 - Page paddings in different modes - updated etalons

* Work for #6578 - Page paddings in different modes - fixed vr-tests

---------

Co-authored-by: tsv2013 <tsv2013@noreply.github.com>
@OlgaLarina OlgaLarina added this to the v1.9.111 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsv2013 tsv2013

@mikeamelin mikeamelin

Labels
bug theme builder website demos
Projects
None yet
Milestone
v1.9.111
Development

Successfully merging a pull request may close this issue.

Fixed #6578 - Page paddings in different modes surveyjs/survey-library
3 participants
@tsv2013 @OlgaLarina @mikeamelin