Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make dateFormat function more efficient #81

Conversation

nagypeterjob
Copy link
Contributor

@nagypeterjob nagypeterjob commented Mar 5, 2023

PR fo #80

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (8a998e5) 97.15% compared to head (5e2f6d2) 97.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   97.15%   97.18%   +0.03%     
==========================================
  Files          12       12              
  Lines         632      639       +7     
==========================================
+ Hits          614      621       +7     
  Misses         18       18              
Impacted Files Coverage Δ
Sources/Puppy/FileRotationLogger.swift 96.40% <100.00%> (+0.13%) ⬆️
Sources/Puppy/LogFormatter.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@sushichop sushichop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This PR makes sense👍
In addition, it's cool that the performance measurement has been added in tests🙂

@sushichop sushichop merged commit 379c2c2 into sushichop:main Mar 6, 2023
@nagypeterjob nagypeterjob deleted the feat-make-date-formatter-more-effieicent branch March 6, 2023 12:42
sushichop added a commit that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants