Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Nested Size Legend #72

Closed
jnschrag opened this issue Nov 17, 2017 · 6 comments
Closed

Feature Request: Nested Size Legend #72

jnschrag opened this issue Nov 17, 2017 · 6 comments

Comments

@jnschrag
Copy link

Hi Susie,

First, thanks for creating and maintaining this plugin - it truly is great! I wanted to request a new feature that would allow you to create a nested legend for the size scales. An example of what I'm talking about is this circular legend.

It would be nice if you could specify the number of items in the legend, although that might be better suited to using the default .ticks() on the scale itself.

Thanks for considering!

@susielu
Copy link
Owner

susielu commented Nov 20, 2017

Hi there, thanks for reaching out about this feature. I think it's a great legend type, but don't have the bandwidth to create it. I'll leave it on here in case anyone is interested in making a pull request to add it.

@jnschrag
Copy link
Author

Fair enough! Are there contributing guidelines anywhere? I might try and give this a go.

@susielu
Copy link
Owner

susielu commented Nov 27, 2017

Oh that would be great! There aren't but you can reference this pull request as an example: #71

@curran
Copy link

curran commented Nov 29, 2017

FWIW, here's an implementation of this legend type using D3 v3, may be worth porting: https://bl.ocks.org/aubergene/4723857
image

@jnschrag
Copy link
Author

Thanks @curran, but I’m aware. That’s the example I linked to in my OP. :)

@susielu
Copy link
Owner

susielu commented May 10, 2019

Thanks, I have no plans on adding in this feature unless someone wants to make a pull request, thanks!

@susielu susielu closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants