Pr/legend locale

[existe-deja]

You can see the tests to understand how it works.
The basic idea:

1. Create a locale object in the legend
2. Adapt labelFormat to use the locale's format. To do it I choose to use a specifier instead of the format function
3. Be sure to support the two ways to set labelFormat, by string or by d3.format

Let me know what to change. When it will be ok for you, I'll do the implementation for sizeLegend and symbolLegend too.

[susielu]

It looks like in the d3-format module it is published with the locale folder, so for this we can import something like d3-format/local/en-US.json and use this as the default definition instead of remaking it here.

[existe-deja]

I agree, this is not the most efficiant way to get the locale. But I'm facing two problems:

1. I cannot access to the default locale, calling d3.formatLocale() without args throws an error
2. I cannot import the locales as simple as you said because of Publish locales as JSON data, not code. d3/d3-format#22 and External access to locale definitions? d3/d3-format#8

Should I import like this?
require('../node_modules/d3-format/locale/en-US.json')
I'm not fan

[existe-deja]

I found an another way, a locale is no more than an object with a format and formatPrefix methods, so I created a default one with the package methods.

[susielu]

Looks good, I just had one comment about the default format. Let me know when it's in the other two legend types and I'll take a look locally and update the docs. Thanks!

[susielu]

This looks good to me, tested it out on the docs and it worked well. Did you have any other changes you wanted to make?

[existe-deja]

I think we're good! It's on your hands now to build and update.
By the way, it was my first open source contribution and I was very happy to do it.

[susielu]

@LaCroute exciting, congrats! It was great having your help to implement this feature. I'll move it in today and update the docs. Cheers!