Feature/improve rc notif 177492071 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 31, 2021 17:08
Y--
approved these changes
Apr 1, 2021
| default: '#testing-ci', | ||
| releaseCandidates: '#release-candidates' | ||
| }; | ||
| const MAX_PRDATE = 1000 * 60 * 5; |
There was a problem hiding this comment.
MAX_PR_DATE would be easier to read, I thought it was a typo for MAX_UPDATE at first :)
Also, don't use DATE as suffix, prefer the real unit for the constant. MINS? SECS? It would document the computation.
| [{ method: 'reply', args: ['Destruction in progress.'] }] | ||
| )); | ||
|
|
||
| it('should notify in an error occurs', async () => |
There was a problem hiding this comment.
You should add a curly bracket at the start of the arrow. It would bring more consistency to this file, and it's often easier to read mocha tests when they all use blocks, as our eyes are very used to this pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT
#177492071
Description
As discussed we want to publish 2 types of information in the
#release-candidateSlack channel.1. Notice that a new version is available on dev
The notification should be sent after the
check-versionjob, to ensure thatdevas been upgraded to the new version.Message should be something like:
2. Notice of what was merged on dev
Here ideally we want one notification by branch that was merged.
For instance if we have a PR on 3 repos, as soon as one repo is merged (usually all of them should be merged pretty much at the same time), we send a notification. We don't send a new notification for the other 2 repos, so we don't duplicate the information (in this channel what is important is to understand the the work that was delivered).
Example message
The PT id comes from the branch name (we ignore if the PR was about multiple PTs).