Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill function call arguments #17

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Fill function call arguments #17

merged 2 commits into from
Jun 13, 2019

Conversation

t-kameyama
Copy link
Contributor 

fun foo(s: String, i: Int) {
}
fun test() {
    foo(<caret>) // Fill function
}

to

fun foo(s: String, i: Int) {
}
fun test() {
    foo(s = "", i = 0)
}

suusan2go
suusan2go requested changes Jun 13, 2019
View reviewed changes
Copy link
Owner

@suusan2go suusan2go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-kameyama
Thank you for great job !
Almost LGTM but I pointed out one.

src/main/kotlin/com/github/suusan2go/kotlinfillclass/intentions/FillClassIntention.kt Outdated
@@ -68,7 +62,7 @@ class FillClassIntention : SelfTargetingIntention<KtValueArgumentList>(KtValueAr
KotlinBuiltIns.isListOrNullableList(type) -> "emptyList()"
KotlinBuiltIns.isSetOrNullableSet(type) -> "emptySet()"
type.isMarkedNullable -> "null"
else -> null
else -> "TODO()"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think TODO() is not preferable. Because this may cause unintentional runtime error if programmer doesn't notice it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

src/test/kotlin/com/github/suusan2go/kotlinfillclass/intentions/FillClassIntentionTest.kt
"Please, add `<caret>` marker to\n$before"
}
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding tests!
Great Job 🍻 🍻 🍻 🍻 🍻

@suusan2go suusan2go merged commit 5f38720 into suusan2go:master Jun 13, 2019
@suusan2go
Copy link
Owner

@t-kameyama Thanks！

@t-kameyama t-kameyama deleted the fill_function branch June 13, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suusan2go suusan2go suusan2go approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-kameyama @suusan2go