Skip to content

Commit

Permalink
enable selfMonitoring so serviceMonitors and others get installed in …
Browse files Browse the repository at this point in the history
…loki helm chart and disable serviceMonitorSelectorNilUsesHelmValues so loki serviceMonitors get honored by kube-prometheus-stack, #60

Signed-off-by: Johannes Kleinlercher <johannes.kleinlercher@suxess-it.com>
  • Loading branch information
jkleinlercher committed Apr 22, 2024
1 parent 3d28fa3 commit 6707c05
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion platform-apps/charts/kube-prometheus-stack/values-k3d.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3515,7 +3515,7 @@ kube-prometheus-stack:
## prometheus resource to be created with selectors based on values in the helm deployment,
## which will also match the servicemonitors created
##
serviceMonitorSelectorNilUsesHelmValues: true
serviceMonitorSelectorNilUsesHelmValues: false

## ServiceMonitors to be selected for target discovery.
## If {}, select all ServiceMonitors
Expand Down
2 changes: 1 addition & 1 deletion platform-apps/charts/loki/values-k3d.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ loki:
# It will create custom resources for GrafanaAgent, LogsInstance, and PodLogs to configure
# scrape configs to scrape its own logs with the labels expected by the included dashboards.
selfMonitoring:
enabled: false
enabled: true
# The Loki canary pushes logs to and queries from this loki installation to test
# that it's working correctly
lokiCanary:
Expand Down

0 comments on commit 6707c05

Please sign in to comment.