add finalizer also in appset apps (#913)

* add finalizer also in appset apps * add finalizer also in multi-stage-app * set resource tracking also on namespace in multi-stage app
suxess-it · Dec 12, 2024 · 7988729 · 7988729
1 parent 0ad0123
commit 7988729
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/platform-apps/charts/team-onboarding/templates/appset-scm-multi-stage-kargo.yaml b/platform-apps/charts/team-onboarding/templates/appset-scm-multi-stage-kargo.yaml
@@ -24,6 +24,8 @@ spec:
   template:
     metadata:
       name: '{{`{{ .repository }}`}}'
+      finalizers:
+      - resources-finalizer.argocd.argoproj.io
     spec:
       project: {{ .name }}-project
       sources:

diff --git a/...ps/onboarding-apps-charts/multi-stage-app-with-kargo-pipeline/templates/applications.yaml b/...ps/onboarding-apps-charts/multi-stage-app-with-kargo-pipeline/templates/applications.yaml
@@ -6,6 +6,8 @@ metadata:
   namespace: {{ $.Release.Namespace }}
   annotations:
     kargo.akuity.io/authorized-stage: {{ tpl $.Values.kargoProject $ }}:{{ .name }}
+  finalizers:
+      - resources-finalizer.argocd.argoproj.io
 spec:
   project: {{ tpl $.Values.appProject $ }}
   source:
@@ -19,6 +21,10 @@ spec:
     server: https://kubernetes.default.svc
     namespace: {{ $.Values.teamName }}-{{ $.Values.appName }}-{{ .name }}
   syncPolicy:
+    managedNamespaceMetadata:
+      annotations:
+        # doesn't handle destinationNamespaceOverride yet
+        argocd.argoproj.io/tracking-id: {{ $.Values.appName }}-{{ .name }}:app/Namespace:{{ $.Values.teamName }}-{{ $.Values.appName }}-{{ .name }}/{{ $.Values.teamName }}-{{ $.Values.appName }}-{{ .name }}
     automated:
       prune: true
       selfHeal: true
@@ -27,4 +33,4 @@ spec:
     - CreateNamespace=true
 {{- end }}
 ---
-{{- end }}
+{{- end }}