Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert back to GITHUB_APPSET_PAT because this is the secret for appse… #885

Closed
wants to merge 2 commits into from

Conversation

jkleinlercher
Copy link
Contributor

…t, not kargo

…t, not kargo

Signed-off-by: Johannes Kleinlercher <johannes.kleinlercher@suxess-it.com>
Copy link

github-actions bot commented Dec 3, 2024

Changes Default Values

Copy link

github-actions bot commented Dec 3, 2024

Changes Rendered Chart
diff -U 4 -r out/target/team-onboarding/values-metalstack.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml out/pr/team-onboarding/values-metalstack.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml
--- out/target/team-onboarding/values-metalstack.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml	2024-12-03 15:09:05.838027284 +0000
+++ out/pr/team-onboarding/values-metalstack.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml	2024-12-03 15:08:36.965983986 +0000
@@ -15,10 +15,10 @@
   target:
     name: appset-github-token
     template:
       data:
-        token: "{{ .GITHUB_TOKEN }}"
+        token: "{{ .GITHUB_APPSET_PAT }}"
   data:
-  - secretKey: GITHUB_TOKEN
+  - secretKey: GITHUB_APPSET_PAT
     remoteRef:
       key: sx-cnp-oss-kv/data/demo/delivery
-      property: GITHUB_TOKEN
+      property: GITHUB_APPSET_PAT
diff -U 4 -r out/target/team-onboarding/values-uibklab.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml out/pr/team-onboarding/values-uibklab.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml
--- out/target/team-onboarding/values-uibklab.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml	2024-12-03 15:09:05.978027394 +0000
+++ out/pr/team-onboarding/values-uibklab.yaml/team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml	2024-12-03 15:08:37.101984404 +0000
@@ -15,14 +15,14 @@
   target:
     name: appset-github-token
     template:
       data:
-        token: "{{ .GITHUB_TOKEN }}"
+        token: "{{ .GITHUB_APPSET_PAT }}"
   data:
-  - secretKey: GITHUB_TOKEN
+  - secretKey: GITHUB_APPSET_PAT
     remoteRef:
       key: sx-cnp-oss-kv/data/demo/delivery
-      property: GITHUB_TOKEN
+      property: GITHUB_APPSET_PAT
 ---
 # Source: team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml
 apiVersion: external-secrets.io/v1beta1
 kind: ExternalSecret
@@ -39,14 +39,14 @@
   target:
     name: appset-github-token
     template:
       data:
-        token: "{{ .GITHUB_TOKEN }}"
+        token: "{{ .GITHUB_APPSET_PAT }}"
   data:
-  - secretKey: GITHUB_TOKEN
+  - secretKey: GITHUB_APPSET_PAT
     remoteRef:
       key: sx-cnp-oss-kv/data/demo/delivery
-      property: GITHUB_TOKEN
+      property: GITHUB_APPSET_PAT
 ---
 # Source: team-onboarding/templates/appset-scm-multi-stage-kargo-es.yaml
 apiVersion: external-secrets.io/v1beta1
 kind: ExternalSecret
@@ -63,10 +63,10 @@
   target:
     name: appset-github-token
     template:
       data:
-        token: "{{ .GITHUB_TOKEN }}"
+        token: "{{ .GITHUB_APPSET_PAT }}"
   data:
-  - secretKey: GITHUB_TOKEN
+  - secretKey: GITHUB_APPSET_PAT
     remoteRef:
       key: sx-cnp-oss-kv/data/demo/delivery
-      property: GITHUB_TOKEN
+      property: GITHUB_APPSET_PAT

@jkleinlercher jkleinlercher deleted the fix/appset-token branch December 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant