Properly handle pug comments in vue files #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually a change in behavior as you might want to use `<!--` comments in pug files.
However I believe that most people would prefer to use this comment style when writing pug files.
I don't know how to collect this data or determine people's preferences here.
I would be amenable to an override system if one was convenient, but I can't seem to `let g:context#commentstring#table['vue']['vue_pug']` in any meaningful way other than adding another autoloader that clobbers these settings or is clobbered by these settings.
I could suggest converting all of these settings to defaults that don't clobber pre-set autoloaded variables.
I can do this conversion, just let me know:
```
let g:context#commentstring#table['vue'] = get(g:, 'context#commentstring#table.vue', {})
let g:context#commentstring#table['vue']['javaScript'] = get(g:, 'context#commentstring#table.vue.javaScript', '//%s')
let g:context#commentstring#table['vue']['cssStyle'] = get(g:, 'context#commentstring#table.vue.cssStyle', '/*%s*/')
```
If we follow this path, I'll update the help page to reflect the new option.
It's definitely not as readable or obvious, but it does prevent clobbering. I can implement it with `if`s too if you would prefer, but that would probably be even worse.
Totally happy to discuss any alternative ways forward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a change in behavior as you might want to use
<!--comments in pug files.However I believe that most people would prefer to use this comment style when writing pug files.
I don't know how to collect this data or determine people's preferences here.
I would be amenable to an override system if one was convenient, but I can't seem to
let g:context#commentstring#table['vue']['vue_pug']in any meaningful way other than adding another autoloader that clobbers these settings or is clobbered by these settings.An Alternative
I suggest converting all of these settings to defaults that don't clobber pre-set autoloaded variables.
I can do this conversion for all settings:
If we follow this path, I'll update the help page to reflect the new functionality.
It's definitely not as readable or obvious, but it does prevent clobbering. I can implement it with
ifs too if you would prefer, but that would probably be even worse.Totally happy to discuss any alternative ways forward!