Bug/Do not replace caller-supplied VRs with UN for unknown Tags #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2021
Open
Closed
suyashkumar
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Thanks @bpeake-illuscio, I think this makes sense! Generally LGTM, but had one question.
Also apologies for the delay--I should be more active this month (had several things going on before).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR closes #193 .
This PR changes the behavior of the writer to default to any existing VR value when we do not have any information on the tag, effectively trusting that the caller knows more than we do about this element. I've added a couple tests to verify this is working as intended, and I've also refactored the logic a bit in
verifyVROrDefaultand added some code comments explaining the intent of certain logic paths.