New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate OwnedValue::from_value in favour of OwnedValue::collect #26

Merged

KodrAus merged 1 commit into sval-rs:master from KodrAus:chore/deprecate-from_value

Jan 23, 2019

Collaborator

KodrAus commented Jan 23, 2019

The OwnedValue::from_value function name didn't make it very obvious what's involved in converting some impl Value into an OwnedValue.

The new OwnedValue::collect name is similar to Iterator::collect, it suggests there's some work involved.


          deprecate OwnedValue::from_value in favour of OwnedValue::collect

69e4ec6

KodrAus merged commit b12ad74 into sval-rs:master

KodrAus deleted the chore/deprecate-from_value branch

January 23, 2019 21:54

KodrAus mentioned this pull request

Prepare for 0.1.2 release #27

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet