Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More stable package find instructions #878

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

ebknudsen
Copy link
Contributor

Please follow these guidelines when making a Pull Request.
This template was adapted from here and here.

Description

Stabililize the search routines for MOAB and double-down

Motivation and Context

  • double-down installs its .cmake-files explicitly to a subdirectory dd. This PR adds that subdir to the search path explicitly. In cases cmake does not find them otherwise
  • The MOAB search directory variable should be quoted. In some cases it can cause FindMOAB to fail. If it is installed to non-standard directory.

Changes

Bug-fix

Behavior

Old behaviour: can cause installation to fail.
New behaviour: more stable installation, less dependent on local cmake parameters.

@ebknudsen ebknudsen changed the title More stable package fin instructions More stable package find instructions Apr 17, 2023
@gonuke
Copy link
Member

gonuke commented Apr 17, 2023

Thanks @ebknudsen - this seems reasonable to me. I suppose we should be testing with DD at some point in our process - perhaps at merge time, even if not during PR review. Thoughts @pshriwise ?

@gonuke gonuke merged commit fe86eac into svalinn:develop Apr 17, 2023
@pshriwise
Copy link
Member

Yes, I agree. I thought we were at some point. Did that go away?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants