Remove yaml-cpp conda pkg from Windows CI env to avoid gtest conflict #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
reviewed
Jul 24, 2023
| - name: Conda dependencies | ||
| shell: bash -l {0} | ||
| run: | | ||
| conda install curl eigen | ||
| conda install -c conda-forge hdf5=1.10.6 | ||
| conda remove -y yaml-cpp |
There was a problem hiding this comment.
interesting I wonder how this one is brought in to the environment.
There was a problem hiding this comment.
conda install with --no-deps would perhas be another option
There was a problem hiding this comment.
We are using a standard miniconda environment as the windows image, so it probably is just there from that process
There was a problem hiding this comment.
... so it's only really relevant for CI, this this is a pretty good solution, I think
shimwell
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes conda pkg
yaml-cppfrom windows CI build environment.Fixes #885
Motivation and Context
The
yaml-cppconda package installs a version ofgtest, currently a version that is not compatible with the one we use. While it is questionable whether this package should installgtest, we don't need this package for our build so we can simply remove it.