Add action to test newer hdf5 version #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to manually launch this action on your fork? Also, please look at the bottom of the README to add a badge for this, as well. |
gonuke
reviewed
Dec 7, 2023
| uses: ./.github/actions/upstream-test | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| hdf5_version: 1.14.0 |
There was a problem hiding this comment.
Should we go straight to 1.14.3 instead?
|
Looks like the workflow for |
|
Thanks @bquan0 - I think this looks OK - go ahead and switch back the README and I'll merge. |
gonuke
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made a copy of one of the
linux_upstream_test.ymlfiles and modified it slightly to use the composite action with an argument ofhdf5_version: 1.14as specified in #916. I'm guessing this is what the issue is asking me to do? I'm not entirely sure because it wasn't specific. The issue also mentions that there are interactions between dependencies, which can be easily added with a matrix in thelinux_upstream_test_hdf5.ymlfile. However, I don't know what interactions need to be tested, so I didn't add the matrix just yet.Behavior
New behavior is that there will be one more action run when PRs are merged to
developthat will test whether DAGMC works with version 1.14 of hdf5.