Overhaul radial distance utility #158

connoramoreno · 2024-09-19T16:52:31Z

Overhauls the radial distance utility. Changes include:

Leveraging recent updates to the magnet workflow
Code restructuring
General code improvements
Addition of a function to handle all radial distance utility functionality, removing the need to call several functions when using the utility
Addition of a function to enforce helical symmetry in a matrix whose rows and columns correspond to regularly spaced angular arrays
Addition of a function to smooth a matrix using Gaussian filtering without increasing the value of matrix elements

parastell/radial_distance_utils.py

…uggested by Edgar

parastell/radial_distance_utils.py

connoramoreno · 2024-09-20T14:50:46Z

I'm beginning to wonder if it might be worth converting this script to an object-oriented version

parastell/radial_distance_utils.py

gonuke

I'm really impressed by the application of best practices here @connoramoreno - nice cleanup! I have a few more comments to continue the journey...

parastell/utils.py

parastell/magnet_coils.py

Examples/radial_distance_example.py

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

gonuke

A little final polish...

parastell/magnet_coils.py

parastell/utils.py

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

… rdu-modifications

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

… rdu-modifications

gonuke

One more comment for posterity

parastell/utils.py

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

gonuke

Thanks for these updates @connoramoreno

connoramoreno added 5 commits September 19, 2024 11:27

Modify code structure

4f124c6

Add utility functions

fc183b0

Rename example file

08c85fb

Uncomment source mesh and DAGMC file generation in example file

6de1b7a

Remove line in example file from testing

68c96e4

Edgar-21 reviewed Sep 19, 2024

View reviewed changes

parastell/radial_distance_utils.py Outdated Show resolved Hide resolved

Change documentation wording in example and modify variable name as s…

5ff0d22

…uggested by Edgar

Edgar-21 reviewed Sep 20, 2024

View reviewed changes

parastell/radial_distance_utils.py Show resolved Hide resolved

Add ability to define custom first wall profile

a119a83

gonuke requested changes Sep 20, 2024

View reviewed changes

parastell/radial_distance_utils.py Outdated Show resolved Hide resolved

parastell/radial_distance_utils.py Outdated Show resolved Hide resolved

parastell/radial_distance_utils.py Outdated Show resolved Hide resolved

parastell/radial_distance_utils.py Outdated Show resolved Hide resolved

connoramoreno added 3 commits September 23, 2024 14:38

Incorporate review suggestions

93ffa4a

Restructure code

98dc878

Modify example

218346f

gonuke requested changes Oct 2, 2024

View reviewed changes

connoramoreno and others added 6 commits October 3, 2024 13:35

Update parastell/magnet_coils.py

11858f5

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Update parastell/magnet_coils.py

9427be2

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Update parastell/utils.py

052f226

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Update parastell/utils.py

263d3e4

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Update parastell/utils.py

12a3fde

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Incorporate review suggestions

b1713bf

gonuke requested changes Oct 5, 2024

View reviewed changes

connoramoreno and others added 7 commits October 8, 2024 16:05

Modify filament toroidal extent check

be845cc

Update parastell/utils.py

eda0183

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Merge branch 'rdu-modifications' of github.com:svalinn/parastell into…

86d4322

… rdu-modifications

Apply suggestions from code review

5707e72

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

Merge branch 'rdu-modifications' of github.com:svalinn/parastell into…

85d7164

… rdu-modifications

Modify matching of first and last halves in enforce_helical_symmetry

ba57ecc

Revert filament toroidal angle checking

cd3f865

gonuke requested changes Oct 9, 2024

View reviewed changes

parastell/utils.py Show resolved Hide resolved

connoramoreno and others added 2 commits October 9, 2024 10:54

Update parastell/utils.py

9b13734

Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>

PEP8 formatting for comments

db6406d

gonuke approved these changes Oct 9, 2024

View reviewed changes

gonuke merged commit ba23085 into main Oct 9, 2024
3 checks passed

connoramoreno deleted the rdu-modifications branch October 9, 2024 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Overhaul radial distance utility #158

Overhaul radial distance utility #158

connoramoreno commented Sep 19, 2024 •

edited

Loading

connoramoreno commented Sep 20, 2024

gonuke left a comment

gonuke left a comment

gonuke left a comment

gonuke left a comment

Overhaul radial distance utility #158

Overhaul radial distance utility #158

Conversation

connoramoreno commented Sep 19, 2024 • edited Loading

connoramoreno commented Sep 20, 2024

gonuke left a comment

Choose a reason for hiding this comment

gonuke left a comment

Choose a reason for hiding this comment

gonuke left a comment

Choose a reason for hiding this comment

gonuke left a comment

Choose a reason for hiding this comment

connoramoreno commented Sep 19, 2024 •

edited

Loading