Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for npm registry auth token #170

Merged

Conversation

fmnxl
Copy link

@fmnxl fmnxl commented Jan 24, 2020

Issue: #151

This is a hacky solution to supporting auth tokens for private registries.

Better solution could be reading from local or the user's .npmrc

TODO

  • Inject curlOptions to fetchurl

@svanderburg
Copy link
Owner

@fmnxl I have integrated your change because it seems to be relatively easy to apply. Just one question: is there an easy way to test the functionality of this? Then I can prevent this feature from breaking in the future, because I'm not using it much myself.

@svanderburg svanderburg merged commit b949c2a into svanderburg:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants