Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish all packages for previews #15

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Aug 27, 2024

we use a script to only publish package previews for modified packages and their dependents. this would normally be fine if our packages were already published to the npm registry as they would have access to their fallbacks, but since that's not the case, we're often met with this error if we wanted to test out the cli via pkg.pr.new:

$ npx https://pkg.pr.new/sveltejs/cli/sv@11 add
Need to install the following packages:
https://pkg.pr.new/sveltejs/cli/sv@11
Ok to proceed? (y) 

npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@svelte-cli%2fast-manipulation - Not found

as a temporary fix, (until we either switch to rolldown where we'll start bundling everything into a single package, or begin publishing our packages to npm), we'll just have pkg.pr.new publish all of our non-privated packages on every run.

@AdrianGonz97 AdrianGonz97 merged commit a875758 into main Aug 28, 2024
3 checks passed
@AdrianGonz97 AdrianGonz97 deleted the chore/preview-publish branch August 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant