Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Node16 and add extensions to all relative imports #28

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

AdrianGonz97
Copy link
Member

This PR is a prerequisite to adding the adder templates into the repo.

While working on migrating over the templates, I noticed that none of the types from the core package were resolving correctly in the adder templates due to our lack of file extensions in relative imports (since we had moduleResolution set to Bundler, it allowed us to have a mix of imports with and without extensions, causing things to break for projects that use moduleResolution: Node16).

Since this is will also be needed for Rolldown in the future, we might as well get this out of the way

Copy link

pkg-pr-new bot commented Sep 17, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-manipulation@28
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@28
pnpm add https://pkg.pr.new/sveltejs/cli/sv@28
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@28

commit: 95e9dc1

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank goodness for allowImportingTsExtensions!

@AdrianGonz97 AdrianGonz97 merged commit d48392f into main Sep 17, 2024
5 checks passed
@AdrianGonz97 AdrianGonz97 deleted the chore/use-ts-extensions branch September 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants