-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vitest
use client and server side testing for kit
#311
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5622141 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
6bf4bec
to
1f5c62e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
requires an update to .gitignore for depending on which tsconfig is used, vitest.workspace.ts needs to be added to that too |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
also if this is combined with |
For |
Does this file get's generated for you? For me i only see
Why should this be necessary? |
Requires further modifications as pointed out by @dominikg here dominikg/vitest-example-svelte5#1 |
those changes are required for vite-6, however given vitest only works with an override (no-go for our cli) or as a beta with that, i suggest we roll back the vite version in our templates to vite-5 until vitest@3 was released and we were able to ensure the config we create actually works. By the time vitest@3 is out, i hope that users that created projects from now till then can just keep using the setup and update versions. If a breaking change in vitest@3 requires a config change, i wonder if we have the ability to run an |
will settle for a closed issue documenting the error and new config may have to share the link a few times but we'll catch up |
Needs the following things to be done
|
Closes #270