Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to $app/state #358

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat: migrate to $app/state #358

merged 2 commits into from
Jan 10, 2025

Conversation

manuel3108
Copy link
Member

Companion for #354 and sveltejs/kit#13140 respectively

  • uses $app/state in the paraglide addon
  • uses $app/state in the demo template

Copy link

changeset-bot bot commented Dec 15, 2024

🦋 Changeset detected

Latest commit: b9ad741

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 15, 2024

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@358
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@358

commit: b9ad741

@manuel3108 manuel3108 marked this pull request as draft December 15, 2024 15:48
@manuel3108 manuel3108 marked this pull request as ready for review December 23, 2024 07:24
@eltigerchino
Copy link
Member

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-cli-358-svelte.vercel.app/

this is an automated message

@manuel3108
Copy link
Member Author

Is it worth updating these test files too?

Good catch, why not. Done.

@eltigerchino eltigerchino merged commit 2c7f7f5 into main Jan 10, 2025
8 checks passed
@eltigerchino eltigerchino deleted the feat/app-state branch January 10, 2025 02:02
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants