Skip to content

fix: use eslint-plugin-svelte v3 #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

fix: use eslint-plugin-svelte v3 #455

merged 3 commits into from
Feb 27, 2025

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Feb 26, 2025

Fixes the version added for eslint-plugin-svelte. It seems like a bad merge added duplicates.

Closes #457

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 27e1b26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Feb 26, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@455
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@455

commit: 27e1b26

@hyunbinseo
Copy link
Contributor

Would this fix an issue where a blank line is added?

    ignores: ["eslint.config.js", "svelte.config.js"], 
 
    languageOptions: { 

hyunbinseo/svelte-kit-templates@fc4b69f#diff-2e101efc857f0a88254190ef0078fd8a7a887f78c948fdb7fed5cb6f9eda240cR27

@AdrianGonz97
Copy link
Member Author

AdrianGonz97 commented Feb 27, 2025

Unfortunately no. That's a separate recast issue with how code is generated from an AST.

Going to self-merge and cut a new release given that it's causing issues for all users running the eslint add-on.

@AdrianGonz97 AdrianGonz97 merged commit 0a375b5 into main Feb 27, 2025
7 checks passed
@AdrianGonz97 AdrianGonz97 deleted the fix/eslint-flat-config branch February 27, 2025 14:38
@github-actions github-actions bot mentioned this pull request Feb 27, 2025
@manuel3108
Copy link
Member

Would this fix an issue where a blank line is added?

This will be fixed once i manage to finalize #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sv 0.6.22 generates a non working eslint configuration
3 participants