Skip to content

fix: addons executed in the wrong order in certain circumstances #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

fix: addons executed in the wrong order in certain circumstances #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc75566
fix: addons executed in the wrong order in certain circumstances
manuel3108 Mar 2, 2025
97f67e5
simplify
manuel3108 Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-icons-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': patch
---

fix: addons executed in the wrong order in certain circumstances
20 changes: 6 additions & 14 deletions packages/cli/lib/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,19 +180,11 @@ async function runAddon({ addon, multiple, workspace }: RunAddon) {
};
}

// sorts them to their execution order
// orders addons by putting addons that don't require any other addon in the front.
// This is a drastic simplification, as this could still cause some inconvenient cituations,
// but works for now in contrary to the previouse implementation
function orderAddons(addons: Array<Addon<any>>, setupResults: Record<string, AddonSetupResult>) {
return Array.from(addons).sort((a, b) => {
const aDeps = setupResults[a.id].dependsOn;
const bDeps = setupResults[b.id].dependsOn;

if (!aDeps && !bDeps) return 0;
if (!aDeps) return -1;
if (!bDeps) return 1;

if (aDeps.includes(b.id)) return 1;
if (bDeps.includes(a.id)) return -1;

return 0;
});
return addons.sort(
(a, b) => setupResults[a.id]?.dependsOn?.length - setupResults[b.id]?.dependsOn?.length
);
}