Skip to content

fix: package manager detection in non interactive environments #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Mar 23, 2025

Closes #502
p.select( was actually throwing, which caused the formatting relevant source code to be skipped.

@hyunbinseo Could you please check if this works for you? pkg-pr-new url will be posted in a second.

Copy link

pkg-pr-new bot commented Mar 23, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@503
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@503

commit: c5db2dc

@hyunbinseo
Copy link
Contributor

It works! This is how I've tested it:

pnpm i https://pkg.pr.new/sveltejs/cli/sv@503 -D
// https://github.com/hyunbinseo/svelte-kit-templates/blob/c4dd93a7559e51f2e8196716f44e0b68e69afc98/index.test.js

import { execSync } from 'node:child_process';

execSync('pnpm sv create --template minimal --no-add-ons --types jsdoc javascript');
execSync('pnpm sv add --no-preconditions --cwd javascript eslint prettier');

execSync('pnpm sv create --template minimal --no-add-ons --types ts typescript');
execSync('pnpm sv add --no-preconditions --cwd typescript eslint prettier');

@manuel3108
Copy link
Member Author

Great that this works! You could probably just have used pnpm https://pkg.pr.new/sveltejs/cli/sv@503 create, the pkg-pr-new comment is still buggy.

@manuel3108 manuel3108 merged commit 5945ea8 into main Mar 24, 2025
7 checks passed
@manuel3108 manuel3108 deleted the fix/package-manager-detection-non-interactive branch March 24, 2025 17:27
@github-actions github-actions bot mentioned this pull request Mar 24, 2025
@manuel3108
Copy link
Member Author

Will be further enhanced by #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format files after pnpm dlx sv add
2 participants