Skip to content

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Aug 31, 2025

Copy link

changeset-bot bot commented Aug 31, 2025

🦋 Changeset detected

Latest commit: 59ef165

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 31, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@681
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@681

commit: 59ef165

Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thank you!

Just made a few tweaks and moved the parser implementation to the cli directory rather than core since it's fairly specific CLI logic.

@jycouet
Copy link
Contributor Author

jycouet commented Sep 1, 2025

Thx for looking at it @AdrianGonz97
I was thinking that it could be usefull for community add-on later on, that's why I've done it in core. (also test setup was already prepared there)

But we can always move it later.

I let you decide 👍

@AdrianGonz97 AdrianGonz97 merged commit 7c71303 into main Sep 1, 2025
8 checks passed
@AdrianGonz97 AdrianGonz97 deleted the fix/parseAddonArgs branch September 1, 2025 20:47
@github-actions github-actions bot mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm dlx sv@latest add drizzle reports an error on new project
2 participants