-
-
Notifications
You must be signed in to change notification settings - Fork 37
fix: use single quotes in new script files #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f32cb21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
packages/ast-tooling/index.ts
Outdated
useTabs: false, | ||
tabWidth: 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll want to default to using tabs instead of spaces
useTabs: false, | |
tabWidth: 4 | |
useTabs: true, | |
tabWidth: undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im starting to really despise recast
, lol. it's still using 2 spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sv create foo
> select tailwind > look at tailwind.config.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hurray! this is awesome!
At this point, this is only a draft. Hopefully we can close this PR entirely later today. |
Superseded by #100 |
I think this would be nice to merge still so that users have a better experience until #100 lands. Unless we think we can land that one before launch. But that could be a lot to do and just add more pressure to get things done |
Good point, although im not sure if this is a major improvement, but it should still be an improvement. |
Did you guys had a chance to test that? Do you think it's generally better or worse? Is there anything that prevents us from merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the title since the "indentation" bit isn't exactly true because of recast
. should be good to go!
Closes #44