Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not run no-reactive-functions rule on Svelte 5 with runes #1017

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

baseballyama
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jan 12, 2025

🦋 Changeset detected

Latest commit: 2bf2c62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

npm i https://pkg.pr.new/eslint-plugin-svelte@1017

commit: 2bf2c62

@baseballyama
Copy link
Member Author

Should we write code that supports Svelte 5?

@baseballyama baseballyama changed the title chore: do not run no-reactive-functions rule on Svelte 5 with runes WIP: chore: do not run no-reactive-functions rule on Svelte 5 with runes Jan 12, 2025
@ota-meshi
Copy link
Member

I think this PR change is enough for the rule 😃

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
No more WIP, right?

@baseballyama baseballyama changed the title WIP: chore: do not run no-reactive-functions rule on Svelte 5 with runes chore: do not run no-reactive-functions rule on Svelte 5 with runes Jan 14, 2025
@baseballyama baseballyama merged commit 806d72a into main Jan 14, 2025
18 checks passed
@baseballyama baseballyama deleted the chore/no-reactive-functions branch January 14, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants