feat: add rule types #735
Merged
feat: add rule types #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0b8690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ota-meshi
requested changes
Apr 11, 2024
Member
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
Thank you for the PR! I didn't know we could do that with type definitions.
ota-meshi
reviewed
Apr 11, 2024
ota-meshi
requested changes
Apr 11, 2024
ota-meshi
reviewed
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707
This PR deviates slightly from the original request; instead of supporting
eslint-define-config, this directly augments ESLint'sLinter.FlatConfigtype:This relies on eslint-typegen.
I've added a new build script in order to preserve the comments in thisrule-types.d.tsfile sincetsconfig.build.jsonremoves them (if there's a better way to do this then please let me know).