Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more sourcemap mappings #37

Merged
merged 3 commits into from
Jan 9, 2025
Merged

add more sourcemap mappings #37

merged 3 commits into from
Jan 9, 2025

Conversation

Rich-Harris
Copy link
Member

WIP — want to add other nodes, and also verify that this works as intended (which is hard to do by eyeballing the generated sourcemaps)

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 32bb8a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

Tested this and it doesn't really change anything — was hoping it would give the browser something to 'latch on to' when trying to find the source of a change.

It's still a minor improvement when looking at stuff in the Svelte playground though, and there's no real reason not to do it, so... I'll do it

@Rich-Harris Rich-Harris marked this pull request as ready for review January 9, 2025 23:45
@Rich-Harris Rich-Harris merged commit 3589e9f into main Jan 9, 2025
6 checks passed
@Rich-Harris Rich-Harris deleted the sourcemap-mappings branch January 9, 2025 23:46
@Rich-Harris Rich-Harris mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant