Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run adapters on CI #382

Closed
benmccann opened this issue Feb 10, 2021 · 1 comment
Closed

Run adapters on CI #382

benmccann opened this issue Feb 10, 2021 · 1 comment
Labels
feature / enhancement New feature or request

Comments

@benmccann
Copy link
Member

benmccann commented Feb 10, 2021 •
edited
Loading

The adapters broke sometime shortly after "@sveltejs/kit": "1.0.0-next.31"

I don't really understand why we have svelte-kit adapt and svelte-kit build and wonder if we should combine them, but if not then maybe we should have npm run build to run both build and adapt (#62 (comment))
@benmccann benmccann added the bug Something isn't working label Feb 10, 2021
This was referenced Feb 10, 2021
Merged
Merged
@benmccann benmccann added feature / enhancement New feature or request and removed bug Something isn't working labels Feb 10, 2021
@benmccann benmccann changed the title adapters are broken Run adapters on CI Feb 10, 2021
@benmccann benmccann mentioned this issue Feb 16, 2021
Closed
4 tasks
@benmccann benmccann mentioned this issue Mar 2, 2021
Closed
@Rich-Harris
Copy link
Member

We're not explicitly running the adapters on CI, but now that build includes adapt it's happening as part of pnpm -r build, so I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature / enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benmccann @Rich-Harris