-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add svelte-kit adapt
package script to create-svelte
projects and every example
#392
Conversation
…ple and test directory
If this is accepted, I'm not in any hurry to get another release of On the other hand, if it's needed / wanted for me to do that, I couldn't find the discussion / vent about what things have to be done to get a new version of something ready for publish after about 15 minutes of searching. |
@Conduitry and I had some questions about what the best way to handle this was in #382 and #62 (comment). I personally would lean towards not having two separate commands or having |
… `build`) in `create-svelte` projects and every example and test directory
…them fail and adapters weren't the point of those tests anyway
adapt
package script to create-svelte
projects and every example and test directoryadapt
package script to create-svelte
projects and every example
adapt
package script to create-svelte
projects and every exampleadapt
package script to create-svelte
projects and every example
adapt
package script to create-svelte
projects and every examplesvelte-kit adapt
package script to create-svelte
projects and every example
The latest commits switch I suspect the examples are failing because they run in parallel, so prerendering one is trying to take resources from another. Thinking of ways to fix it / figuring out where to, so I marked this PR as a WIP. |
yeah, I've come to the view that |
Addressed by #430 |
Before submitting the PR, please make sure you do the following
adapt
. This isn't intended to address the separation ofbuild
andadapt
, but to just makeadapt
readily available since it is currently necessary to "complete" a build. Feel free to revise or reject this PR if e.x. the commands should be merged instead, making this useless.Tests
npm test
and lint the project withnpm run lint
.