Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changeset missing from #6586. Change not in changelog #6664

Closed
kevinrenskers opened this issue Sep 8, 2022 · 3 comments · Fixed by #6675
Closed

Changeset missing from #6586. Change not in changelog #6664

kevinrenskers opened this issue Sep 8, 2022 · 3 comments · Fixed by #6675

Comments

@kevinrenskers
Copy link

Describe the problem

The changelog is missing entries about recent changes to error handling and hooks.

Describe the proposed solution

It would be a good idea to add this to the changelog because they're breaking changes.

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response
@benmccann
Copy link
Member

Can you link to exactly which changes you're talking about?

@kevinrenskers
Copy link
Author

For example the new split client and server hooks (https://kit.svelte.dev/docs/hooks) and the new typed PageError stuff (https://kit.svelte.dev/docs/types#app-pageerror).

@kevinrenskers
Copy link
Author

I guess ultimately it's #6586 that is missing from the changelog?

@benmccann benmccann changed the title The changelog is missing entries about recent changes to error handling and hooks. Changeset missing from #/6586 Sep 8, 2022
@benmccann benmccann changed the title Changeset missing from #/6586 Changeset missing from #6586 Sep 8, 2022
@benmccann benmccann changed the title Changeset missing from #6586 Changeset missing from #6586. Change not in changelog Sep 8, 2022
dummdidumm added a commit that referenced this issue Sep 8, 2022
@dummdidumm
[fix] error cleanup rework
afdf41d 
- add missing changeset, closes #6664
- enhance docs, closes #6669
- fix fallback message in client
@dummdidumm dummdidumm mentioned this issue Sep 8, 2022
Merged
5 tasks
Rich-Harris pushed a commit that referenced this issue Sep 8, 2022
@dummdidumm
[fix] error cleanup rework (#6675)
31f829d 
- add missing changeset, closes #6664
- enhance docs, closes #6669
- fix fallback message in client
@Conduitry Conduitry mentioned this issue Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] error rework cleanup sveltejs/kit
2 participants
@kevinrenskers @benmccann