Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sverdle guesses not visible using JS #7238

Closed
rescribet opened this issue Oct 11, 2022 · 0 comments · Fixed by #7241
Closed

Sverdle guesses not visible using JS #7238

rescribet opened this issue Oct 11, 2022 · 0 comments · Fixed by #7241

Comments

@rescribet
Copy link

Describe the bug

The sverdle game is broken, looks like #7207 will clear the values while the value (value={guesses[row]?.[column] ?? ''}) won't be set in the DOM.

Seems to be introduced in 1.0.0-next.512, and 1.0.0-next.513 doesn't fix it yet.

Screenshot 2022-10-11 at 23 45 50

Reproduction

  • Clone repo (It's a fresh repo with npm create svelte@latest. I chose typescript and all other options.)
  • Start svelte and open sverdle page
  • Enter word, see previous values cleared
  • Remove use:enhance and see form work with js enabled
  • Restore use:enhance
  • Downgrade @sveltejs/kit to 1.0.0-next.511
  • See form work again

Logs

No response

System Info

System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Pro
    Memory: 117.14 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.asdf/installs/nodejs/16.15.0/bin/node
    Yarn: 1.22.18 - ~/.asdf/installs/nodejs/16.15.0/.npm/bin/yarn
    npm: 8.5.5 - ~/.asdf/plugins/nodejs/shims/npm
  Browsers:
    Brave Browser: 104.1.42.86
    Chrome: 106.0.5249.103
    Safari: 16.0
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0-next.82 => 1.0.0-next.82 
    @sveltejs/kit: 1.0.0-next.513 => 1.0.0-next.513 
    svelte: ^3.51.0 => 3.51.0 
    vite: ^3.1.7 => 3.1.7

Severity

annoyance

Additional Information

No response

dummdidumm pushed a commit that referenced this issue Oct 12, 2022
fixes #7238
provides a custom form enhance callback for the demo app /sverdle to prevent form.reset() being called by the default callback.

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant