-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New hello world #1014
New hello world #1014
Conversation
Looks like you need to run prettier on |
packages/create-svelte/templates/default/src/lib/Counter/minus.svg
Outdated
Show resolved
Hide resolved
lgtm. thanks @rafaelcamaram for blazing the trail here! |
I'll look for them asap. |
Perhaps a bit off-topic, but the thing that's always bugged me about create-svelte is that it dumps the files in your current directory. I'd like it if it asked you for your project name and created a new directory and put the files there |
Thanks @vedam — have made those changes: I did wonder about the deferred transition example — I was worried that it might be a bit too much for an introductory page, since it's quite advanced stuff that isn't totally obvious on first glance. We're tracking the API stuff on sveltejs/api.svelte.dev#2. Once that's done, next step will be to figure out a way to deploy this demo app with the various adapters — it can take the place of https://github.com/sveltejs/kit/tree/master/examples/svelte-kit-demo (or this app could go there, and the |
@@ -0,0 +1,89 @@ | |||
import fetch from 'node-fetch'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still a bit unsure about hitting a real api. Couldn't we do a mock here instead and write to local storage? If everyone else uses the db interface we can showcase these things just the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't make an app that works without JS if you rely on localStorage
A general thought: should the the app be enhanced with a couple of comments explaining the various features showcased here with a link to the docs? Like "the load function can be used to fetch data. See -link- for more info". Else if someone jumps right in without reading the docs first it could be a little overwhelming. |
Yep, added some docs, and we can certainly add more |
API is rigged up, so I'll merge this in even though there's doubtless room for improvement. Next stop after this is released will be to get it deployed with the various different adapters |
Following up @rafaelcamaram's work in #1007 with a few changes:
pnpm dev
inside the template, for easier developingIt would also be cool if this template was the demo app referred to in #639. To that end we may want to test/showcase various features:
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts