Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tiny-glob dependency #10166

Merged
merged 2 commits into from
Jun 16, 2023
Merged

chore: remove tiny-glob dependency #10166

merged 2 commits into from
Jun 16, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jun 15, 2023

This change makes kit a bit smaller so that learn.svelte.dev will load just a bit faster. Removes 3 deps weighing in at a total of 41k

I was surprised to see tiny-glob as a dependency because I thought removed all glob deps in #2430, but maybe we missed one or it got added back

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: f24f530

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member Author

I'm going to go ahead and add a changeset for this one since fewer dependencies is somewhat user visible

@utkarshkukreti
Copy link
Contributor

Looks like

import glob from 'tiny-glob/sync.js';
still uses tiny-glob, see #10173.

@benmccann
Copy link
Member Author

thanks for the ping. I just sent a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants