Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specified 'initial-scale=1' on all viewport meta tags #10793

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

DougInAMug
Copy link
Contributor

This PR reverts #5706. #5706 removed the initial-scale=1 specification from the <meta name="viewport" > tags used for templating, on the basis that specification was no longer needed, since browsers should default to 1.

However, Chrome-based browsers don't do this, causing design and accessibility issues:

Screencast.from.27-09-23.14.33.39.webm

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
    • pnpm test runs successfully, didn't lint or check.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: efc74ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

A note to reviewers that some comments have been posted on the original PR: #5706 (comment). We can wait a little bit and see if the original author responds

@benmccann benmccann changed the title specified 'initial-scale=1' on all viewport meta tags fix: specified 'initial-scale=1' on all viewport meta tags Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants