-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter bundle #1091
Adapter bundle #1091
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sveltejs/kit-demo/3AHB186gqcGRxrwTR1o6hkgCSGud |
This is a little tricky to test without actually releasing new adapter versions and trying to deploy stuff with them, so I'm going to do exactly that |
Mostly just playing around for now, but this is intended to solve the perennial problem of dependencies behaving weirdly, by allowing adapters to determine what gets bundled.
For example,
adapter-node
doesn't need to bundle anything, but an adapter for a serverless platform might. Right now I'm trying to get esbuild to bundle everything inside the Vercel adapter, but it's possible that this belongs in an adapter util.admin
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts