Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suggest running svelte-migrate with latest if migration does not exist #11362

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

geoffrich
Copy link
Member

Sometimes we forget to add @latest to the svelte-migrate instructions. This PR updates the error for a missing migration to suggest re-running with latest.

Of course, people on older versions won't get this helpful error, but maybe it will be useful eventually.

Related: #11359, #11360

Example of new error:

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 16, 2023

🦋 Changeset detected

Latest commit: dfcfcc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

Can we check the command that was run to see if @latest was specified or does it not see it?

@geoffrich
Copy link
Member Author

I don't think we have access to that -- @latest only tells npx which version of svelte-migrate to use. We could probably check the version in package.json against the latest version in the registry, but that complexity doesn't seem worth it.

@Rich-Harris Rich-Harris merged commit 975ec9c into master Dec 18, 2023
13 checks passed
@Rich-Harris Rich-Harris deleted the grich/migrate-latest branch December 18, 2023 17:04
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants