Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed deprecated config.package type #11462

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Dec 24, 2023

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Support for config.package was removed in #8922 (10 month ago) but the type declaration survived the svelte-kit v2 major version. I guess it should be removed now, as I tried using it (encouraged by the type declaration) and failed with this message

> config.package is no longer supported. See https://github.com/sveltejs/kit/discussions/8825 for more information.
    at load_config (file:///@sveltejs/package/src/config.js:21:9)
    at async file:///@sveltejs/package/src/cli.js:29:19

It may be time to remove this message too, it can be found here:

https://github.com/sveltejs/kit/blame/main/packages/package/src/config.js#L20-L24

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Dec 24, 2023

🦋 Changeset detected

Latest commit: e142eb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 0143819 into sveltejs:main Jan 4, 2024
10 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
@GauBen
Copy link
Contributor Author

GauBen commented Jan 4, 2024

You're welcome!

Should we remove these lines too?

if (config.package) {
throw new Error(
'config.package is no longer supported. See https://github.com/sveltejs/kit/discussions/8825 for more information.'
);
}

@dummdidumm
Copy link
Member

No, we should do this in @sveltejs/package version 3 (so that people upgrading from 1 to 2 get a good error message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants