Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-svelte): install eslint-plugin-svelte@next for svelte5 #11627

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

ghostdevv
Copy link
Member

Installs eslint-plugin-svelte version ^2.36.0-next.4 when selecting Svelte 5

Closes #11530


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 6962b8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 22ed677 into main Jan 12, 2024
13 checks passed
@Rich-Harris Rich-Harris deleted the fix-svelte5-eslint branch January 12, 2024 21:53
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
@benmccann
Copy link
Member

I'm not super familiar with how the create-svelte templates work. Do we need to change +eslint to +eslint-svelte5 so that we don't end up with two versions of eslint for Svelte 5 users?

@Rich-Harris
Copy link
Member

No, the more specific variants override the less specific ones, and package.json is merged on that basis

@manning390
Copy link

Could be a version target issue, but I just tried to install sveltekit with svelte@next and got eslint-plugin-svelte3

Just not out yet?

Screenshot 2024-01-18 at 1 44 13 PM

@dummdidumm
Copy link
Member

@next is severely outdated, it refers to the last beta version of SvelteKit. Use @latest

@Bishwas-py
Copy link
Contributor

what's the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error resolving eslint-plugin-svelte@2.35.1 while using svelte5-alpha via the create CLI
6 participants