Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure generated tsconfig paths start with ./ if aliasing to ./svelte-kit #12220

Merged
merged 4 commits into from
May 16, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented May 16, 2024

fixes #12169

Appends a "./" to the generated tsconfig path so that aliases to files in .svelte-kit/... don't cause the user's tsconfig.json to complain about non-relative paths.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 98288a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: ensure generated tsconfig path always starts relative to the current directory fix: ensure generated tsconfig path starts relative to the current directory May 16, 2024
@eltigerchino eltigerchino changed the title fix: ensure generated tsconfig path starts relative to the current directory fix: ensure generated tsconfig paths start with ./ if aliasing to ./svelte-kit May 16, 2024
@eltigerchino eltigerchino marked this pull request as ready for review May 16, 2024 14:31
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
"@sveltejs/kit": patch
---

fix: correctly handle aliases to files in the `.svelte-kit` directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, maybe it'd be more accurate or comprehensive to say:

Suggested change
fix: correctly handle aliases to files in the `.svelte-kit` directory
fix: correctly handle aliases to files in hidden directories

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that's right. The only issue was that aliases to files in .svelte-kit did not start with a leading ./ so tsconfig considered them to be non-relative paths and complained e.g. "types/routes/src/*"

@eltigerchino eltigerchino merged commit 7b72c11 into main May 16, 2024
13 checks passed
@eltigerchino eltigerchino deleted the fix-tsconfig-complaint branch May 16, 2024 23:25
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with kit.alias for $types
2 participants