-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure generated tsconfig paths start with ./
if aliasing to ./svelte-kit
#12220
Conversation
🦋 Changeset detectedLatest commit: 98288a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
./
if aliasing to ./svelte-kit
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
"@sveltejs/kit": patch | ||
--- | ||
|
||
fix: correctly handle aliases to files in the `.svelte-kit` directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, maybe it'd be more accurate or comprehensive to say:
fix: correctly handle aliases to files in the `.svelte-kit` directory | |
fix: correctly handle aliases to files in hidden directories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that's right. The only issue was that aliases to files in .svelte-kit did not start with a leading ./ so tsconfig considered them to be non-relative paths and complained e.g. "types/routes/src/*"
fixes #12169
Appends a
"./"
to the generated tsconfig path so that aliases to files in.svelte-kit/...
don't cause the user's tsconfig.json to complain about non-relative paths.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits