Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to @rollup/plugin-commonjs@26 #12326

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

Conduitry
Copy link
Member

This updates the version of @rollup/plugin-commonjs in the Node and Netlify adapters to remove their deprecated dependencies on glob and inflight.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: c4109f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member Author

I don't think these couple of test failures are related, but would appreciate someone else's eyes on them.

@Conduitry
Copy link
Member Author

I was just really confused about #12300, but then I realized that that PR didn't actually do what it said. 😭

The failures here also seem to match the ones in #12298, but I still really don't know how they could be caused by this change.

@benmccann
Copy link
Member

Oops. My bad on that PR description.

I think the test failure was just a flake. Rerunning it now...

@benmccann benmccann merged commit b6202dd into sveltejs:main Jun 12, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants