-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adhere to Vite build.minify
setting when building service worker
#13143
Conversation
🦋 Changeset detectedLatest commit: e777827 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13143-svelte.vercel.app/ this is an automated message |
...vite_config, | ||
build: { | ||
...vite_config.build, | ||
minify: initial_config.build?.minify ?? 'esbuild' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to use initial_config instead of vite_config here, and/or not fall back to its minify option first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, vite_config
is changed to the Vite client build default settings instead of the user's config at this stage. For that same reason, we're also passing the initial_config
value when building the client bundle:
kit/packages/kit/src/exports/vite/index.js
Line 808 in 33600ee
minify: initial_config.build?.minify, |
closes #11790
This PR passes the user's Vite
build.minify
config value to the Vite build for the service worker.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits