Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adhere to Vite build.minify setting when building service worker #13143

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

eltigerchino
Copy link
Member

closes #11790

This PR passes the user's Vite build.minify config value to the Vite build for the service worker.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the service worker Stuff related to service workers label Dec 11, 2024
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: e777827

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13143-svelte.vercel.app/

this is an automated message

...vite_config,
build: {
...vite_config.build,
minify: initial_config.build?.minify ?? 'esbuild'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to use initial_config instead of vite_config here, and/or not fall back to its minify option first?

Copy link
Member Author

@eltigerchino eltigerchino Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, vite_config is changed to the Vite client build default settings instead of the user's config at this stage. For that same reason, we're also passing the initial_config value when building the client bundle:

minify: initial_config.build?.minify,

@dummdidumm dummdidumm merged commit a1fea7e into main Dec 12, 2024
14 checks passed
@dummdidumm dummdidumm deleted the dont-minify-service-worker branch December 12, 2024 16:20
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service worker Stuff related to service workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vite build minify: false options do not affect service-worker
3 participants