Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigate without reloading for links with a target attribute that will display in the current browsing context #13165

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Dec 16, 2024

fixes #13162

This PR corrects the external link condition by also checking the target type instead of just the presence of the target attribute. Now links that open in the same browsing context won't be treated as external.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 166d9e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: navigate without reloading for links with explicit target attribute and open in the current browsing context fix: navigate without reloading for links with a target attribute and will display in the current browsing context Dec 16, 2024
@eltigerchino eltigerchino changed the title fix: navigate without reloading for links with a target attribute and will display in the current browsing context fix: navigate without reloading for links with a target attribute that will display in the current browsing context Jan 6, 2025
@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13165-svelte.vercel.app/

this is an automated message

@@ -136,7 +136,7 @@ export function get_link_info(a, base, uses_hash_router) {

const external =
!url ||
!!target ||
target === '_blank' ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be this instead? We can't know for certain if the browsing context will be the same as ours for _top etc

Suggested change
target === '_blank' ||
(target || '_self') !== '_self' ||

Copy link
Member Author

@eltigerchino eltigerchino Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would location.ancestorOrigins work to check if there are no parents/ancestors? https://developer.mozilla.org/en-US/docs/Web/API/Location/ancestorOrigins

If there is a way to check for parent browsing contexts then the page wouldn't need to reload when these values should behave similar to _self.

_parent: The parent browsing context of the current one. If no parent, behaves as _self.

_top: The topmost browsing context. To be specific, this means the "highest" context that's an ancestor of the current one. If no ancestors, behaves as _self.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#target

@Conduitry
Copy link
Member

Using target=_self as a way to indicate to an SPA framework that a given link should be treated normally rather than being intercepted predates SvelteKit. There are a number of frameworks that work this way. It may not have ever been documented in SK's docs - and there may be other official SK-specific ways of doing this - but I don't think we can just remove it. At the very least, removing this should be a breaking change.

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@eltigerchino eltigerchino added this to the 3.0 milestone Jan 17, 2025
@dummdidumm dummdidumm added the needs-decision Not sure if we want to do this yet, also design work needed label Jan 17, 2025
@eltigerchino eltigerchino marked this pull request as draft January 22, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change needs-decision Not sure if we want to do this yet, also design work needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page transitions don't work if <a> tag has target attribute set (even to '_self')
4 participants