fix: do not mutate URL during reroute logic #13222
Merged
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: daf8475 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
approved these changes
Dec 22, 2024
dummdidumm
commented
Dec 22, 2024
|
|
||
| await page.goto('/'); | ||
|
|
||
| await page.locator('a[href="/#/reroute-b"]').click(); | ||
| await expect(page.locator('p')).toHaveText('rerouted'); | ||
| url = new URL(page.url()); | ||
| expect(url.hash).toBe('#/rerouted'); | ||
| expect(url.hash).toBe('#/reroute-b'); |
There was a problem hiding this comment.
turns out there even was a test that could've caught this, but the test assertion was wrong. The reroute hooks does neither influence page.url nor the browser url.
|
preview: https://svelte-dev-git-preview-kit-13222-svelte.vercel.app/ this is an automated message |
Merged
|
Thanks for fixing the bug so quickly @dummdidumm. Enjoy the holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13220
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.