Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: don't advise to use loading="eager" on images because it's already the default #13228

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

bfontaine
Copy link
Contributor

Hello,

loading="eager" is already the default, so adding it explicitely doesn’t change anything. This PR removes this advice from the docs.

See:


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [not applicable] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • [not applicable] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [not applicable] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [not applicable] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 107427a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13228-svelte.vercel.app/

this is an automated message

@benmccann benmccann added the documentation Improvements or additions to documentation label Dec 23, 2024
@eltigerchino eltigerchino changed the title Don't advise to use loading="eager" on images because it's already the default docs: don't advise to use loading="eager" on images because it's already the default Dec 24, 2024
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eltigerchino eltigerchino merged commit c0ca073 into sveltejs:main Dec 26, 2024
14 checks passed
@bfontaine bfontaine deleted the patch-1 branch December 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants