Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM #1323

Merged
merged 20 commits into from
May 4, 2021
Merged

ESM #1323

merged 20 commits into from
May 4, 2021

Conversation

Rich-Harris
Copy link
Member

Converts config files to ESM and renames them from svelte.config.cjs to svelte.config.js, adds a message telling you to convert existing svelte.config.cjs files, and converts adapters to ESM.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Copy link
Member Author

Accidentally included #1321 commits. Oh well

@furudean
Copy link
Contributor

furudean commented May 3, 2021

(hooting and hollering)

@rchrdnsh
Copy link

rchrdnsh commented May 4, 2021

yeehaw :-)

@Rich-Harris
Copy link
Member Author

the build isn't going to succeed until the packages themselves are updated, so i'm going to merge and release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants