Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prerender data when there's no server load but trailingSlash option is set from the server #13262

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jan 2, 2025

fixes #13255

This PR ensures that the __data.json file is prerendered when the trailingSlash option is set from a +page.server or +layout.server file although no server load exists. The data file is needed because the client relies on the server data to get the trailingSlash option value.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: b4729a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: prerender data when there's no server load but trailingSlash option is set from the server fix: prerender data when there's no server load but trailingSlash option is set from the server Jan 2, 2025
@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13262-svelte.vercel.app/

this is an automated message

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/kit/src/runtime/server/page/index.js Show resolved Hide resolved
@dummdidumm dummdidumm merged commit 80a9e83 into main Jan 6, 2025
14 checks passed
@dummdidumm dummdidumm deleted the fix-trailing-slash-server-prerender branch January 6, 2025 10:42
@github-actions github-actions bot mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting trailingSlash = "always" in layout with a srr = false page causes 404 errors in prod
3 participants